Re: [TopGit PATCH] tg-graph: print dependency graph like git log --graph

From

Bert Wesarg <bert.wesarg@googlemail.com>

Date

May 19, 2009, 16:45 UTC

Message-ID

<36ca99e90905190945m1ecea6bka99946783ea1d22a@mail.gmail.com>

In-Reply-To

<36ca99e90905190732g53599cb8y142a137bc79ad655@mail.gmail.com>

On Tue, May 19, 2009 at 16:32, Bert Wesarg <bert.wesarg@googlemail.com> wrote:

> On Tue, May 19, 2009 at 16:14, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
>> On Tue, May 19, 2009 at 16:09, Michael Radziej <mir@noris.de> wrote:
>>> I see another issue. On a quite complicated repository, I did the "tg
>>> summary --graphviz ... edit ...  graphviz ..." dance, and there I get the
>>> following output:
>>>
>>> mir@mir:otrs-git$ cat /tmp/graph | gvpr -f ~/src/topgit/share/graph.gvpr
>>> gvpr: "/home/mir/src/topgit/share/graph.gvpr", line 936: gg_nl_ret +=
>>> graph_output_commit_line();<<<
>>>  -- cannot convert node_t to string
>> Ok, still two unrelated problems.
> And still I can't reproduce it here :(

I found a missing rename which causes random segfaults.

Here the diff:

--- a/share/graph.gvpr
+++ b/share/graph.gvpr
@@ -523,7 +523,7 @@ BEGIN {
                  * print the branch lines as "|".
                  */
                 if (gg_prev_state == GRAPH_POST_MERGE &&
-                    gg_prev_commit_index < gg_opcl_i)
+                    gg_prev_n_index < gg_opcl_i)
                     gg_opcl_sb += gg_write_column(gg_columns[gg_opcl_i], "\\");
                 else
                     gg_opcl_sb += gg_write_column(gg_columns[gg_opcl_i], "|");

patch tomorrow

Bert