Re: [PATCH 1/3] add alloc_ref_with_prefix()

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Oct 18, 2008, 12:07 UTC
Message-ID: <36ca99e90810180507q2dedf4ck7262239ae91d892f@mail.gmail.com>
In-Reply-To: <48F9AECA.3020606@lsrfire.ath.cx>

On Sat, Oct 18, 2008 at 11:39, René Scharfe <rene.scharfe@lsrfire.ath.cx> wrote:

Show 10 quoted lines

>>> +static struct ref *alloc_ref_with_prefix(const char *prefix, size_t prefixlen,
>>> +               const char *name)
>>> +{
>>> +       size_t len = strlen(name);
>>> +       struct ref *ref = xcalloc(1, sizeof(struct ref) + prefixlen + len + 1);
>>> +       memcpy(ref->name, prefix, prefixlen);
>>> +       memcpy(ref->name + prefixlen, name, len);
>> Where does you \0-terminate the string?
>
> xcalloc() calls calloc(), which zeroes the memory.

So, you write the memory range twice, just for the last \0?

Bert

>
> René
>