Re: [TopGit RFC PATCH] tg mail: new command for mailing patches

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Sep 19, 2008, 10:20 UTC
Message-ID: <36ca99e90809190320l4765e50eqe38bf1d2672cfcca@mail.gmail.com>
In-Reply-To: <20080919100441.GF4423@roro3>

On Fri, Sep 19, 2008 at 12:04, Kirill Smelkov <kirr@landau.phys.spbu.ru> wrote:

Show 19 quoted lines

> On Fri, Sep 19, 2008 at 11:52:03AM +0200, Bert Wesarg wrote:
>> On Fri, Sep 19, 2008 at 11:08, Kirill Smelkov <kirr@landau.phys.spbu.ru> wrote:
>> > Petr, since you've asked for help on this, here you are:
>> >
>> >    $ tg mail [NAME]
>> >
>> > a simple script to send one patch over email.
>> >
>> >
>> > All it does is
>> >
>> >    - call `tg patch` for actual patch preparation
>> >    - extract email addresses from whom and where to send a mail
>> That shouldn't be needed. git send-email parses Cc: headers and the
>
> Exactly for this reason I do not extract Cc. And git send-mail does not
> extract From: -- it just asks to confirm From is GIT_COMMITTER_IDENT,
> and there is no option to stop it doing so except providing explicit
> --from <someone> (maybe i'm missing something?).

Ahh, my fault, I should take a break, sorry for the noise.

Show 6 quoted lines

>
>> To: comes from 'git config topgit.to', so you can re-use this.
>
> Yes, it comes directly to .topmsg when `tg create` is done, so I thought
> the main source of information is the patch itself -- users may want to
> edit that To: by hand or add another To: lines.

Yeah, my fault, I noticed this too, its just a template. better to extract it from the patch.

Show 9 quoted lines

>
> and what If a patch is already exported as a file, and I want to
> send/resend it upstream right from that file?
>
> We may want to look for topgit.to too though.
>
> --
>    Всего хорошего, Кирилл.
>