git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] for-each-ref: `:short` format for `refname`

From
Bert Wesarg <bert.wesarg@googlemail.com>
Date
Sep 1, 2008, 21:10 UTC
Message-ID
<36ca99e90809011410w646cc6eajb3063ea3501f173c@mail.gmail.com>
In-Reply-To
<20080901191051.GD7482@spearce.org>
On Mon, Sep 1, 2008 at 21:10, Shawn O. Pearce <spearce@spearce.org> wrote:
Show 31 quoted lines
> Bert Wesarg <bert.wesarg@googlemail.com> wrote:
>> IMHO the goal of this new format for refname should be, that it can be
>> used as an ref on the command line. This isn't given with my current
>> :short proposal (which I call :strip as of now), as Gábor showed. What
>> we need is the reverse of what happened with refnames given on the
>> command line to commands like checkout/merge/... The only thing that
>> comes near to this is this from refs.c:
>>
>>     const char *ref_rev_parse_rules[] = {
>>             "%.*s",
>>             "refs/%.*s",
>>             "refs/tags/%.*s",
>>             "refs/heads/%.*s",
>>             "refs/remotes/%.*s",
>>             "refs/remotes/%.*s/HEAD",
>>             NULL
>>     };
>>
>> Which doesn't look very useful, because every ref from for_each_ref
>> would match rule one. So we probably need to try the reverse of this
>> list.
>
> Yup.  If you search the list backwards and extract the part of the
> ref that matches %.*s you'll get a name that other tools can find,
> and which is the shortest name possible.
>
> You can still get ambiguous names.  Avoiding them requires going
> through all refs and building their short forms, then using the
> full ref name for any ref which had more than one name shorten to
> the same string.  Ugly, but implementable, and probably something
> that should be considered.

What about: try the list backwards until the first match, than try the matched part (this what %.*s matched) with the forward list, if both give the same pattern, its not disambiguous. If not try the next pattern backwards.

Its quadratic in the number of patterns, but this is maybe smaller than scanning all refs (which may include a sort phase).

Bert
> --
> Shawn.
>
Previous: Shawn O. PearceNext: Junio C Hamano
Message 6 of 26 in “for-each-ref: `:short` format for `refname`”
  1. for-each-ref: `:short` format for `refname`Bert Wesarg, Aug 31, 2008
  2. SZEDER GáborSep 1, 2008
  3. Bert WesargSep 1, 2008
  4. Bert WesargSep 1, 2008
  5. Shawn O. PearceSep 1, 2008
  6. Bert WesargSep 1, 2008
  7. Junio C HamanoSep 1, 2008
  8. Bert WesargSep 1, 2008
  9. Bert WesargSep 2, 2008
  10. Shawn O. PearceSep 2, 2008
  11. for-each-ref: `:short` format for `refname`Bert Wesarg, Sep 2, 2008
  12. Junio C HamanoSep 2, 2008
  13. Bert WesargSep 3, 2008
  14. for-each-ref: `:short` format for `refname`Bert Wesarg, Sep 3, 2008
  15. Shawn O. PearceSep 3, 2008
  16. Bert WesargSep 3, 2008
  17. Bert WesargSep 3, 2008
  18. Junio C HamanoSep 3, 2008
  19. for-each-ref: `:short` format for `refname`Bert Wesarg, Sep 5, 2008
  20. Junio C HamanoSep 5, 2008
  21. Bert WesargSep 6, 2008
  22. Junio C HamanoSep 8, 2008
  23. Shawn O. PearceSep 8, 2008
  24. Bert WesargSep 9, 2008
  25. Junio C HamanoSep 9, 2008
  26. Bert WesargSep 9, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.