Re: TOPGIT: [PATCH] Use standard prefix and DESTDIR rather than explain

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Aug 12, 2008, 16:34 UTC
Message-ID: <36ca99e90808120934h6d86a7cbpeca8a6c85ba3bce2@mail.gmail.com>
In-Reply-To: <1218545670.7264.2.camel@heerbeest>

On Tue, Aug 12, 2008 at 14:54, Jan Nieuwenhuizen <janneke-list@xs4all.nl> wrote:

Show 38 quoted lines

> First an install nitpick.
>
>
>
> Signed-off-by: Jan Nieuwenhuizen <janneke@gnu.org>
> ---
>  Makefile |   26 +++++++++++++-------------
>  1 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 6eade1e..ea6489e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1,8 +1,7 @@
> -# Set PREFIX to wherever you want to install TopGit
> -PREFIX = $(HOME)
> -bindir = $(PREFIX)/bin
> -cmddir = $(PREFIX)/libexec/topgit
> -sharedir = $(PREFIX)/share/topgit
> +prefix = $(HOME)
> +bindir = $(prefix)/bin
> +cmddir = $(prefix)/libexec/topgit
> +sharedir = $(prefix)/share/topgit
>  hooksdir = $(cmddir)/hooks
>
>
> @@ -31,14 +30,15 @@ $(help_out): README
>        ./create-help.sh $$CMD
>
>  install:: all
> -       install -d -m 755 "$(bindir)"
> -       install tg "$(bindir)"
> -       install -d -m 755 "$(cmddir)"
> -       install $(commands_out) "$(cmddir)"
> -       install -d -m 755 "$(hooksdir)"
> -       install $(hooks_out) "$(hooksdir)"
> -       install -d -m 755 "$(sharedir)"
> -       install -m 644 $(help_out) "$(sharedir)"

> +       install -d -m 755 "$(DESTDIR)$(bindir)"
> +       install -d -m 755 "$(DESTDIR)$(bindir)"

duplicate

Bert

Show 23 quoted lines

> +       install tg "$(DESTDIR)$(bindir)"
> +       install -d -m 755 "$(DESTDIR)$(cmddir)"
> +       install $(commands_out) "$(DESTDIR)$(cmddir)"
> +       install -d -m 755 "$(DESTDIR)$(hooksdir)"
> +       install $(hooks_out) "$(DESTDIR)$(hooksdir)"
> +       install -d -m 755 "$(DESTDIR)$(sharedir)"
> +       install -m 644 $(help_out) "$(DESTDIR)$(sharedir)"
>
>  clean::
>        rm -f tg $(commands_out) $(hooks_out) $(help_out)
> --
> 1.6.0.rc0.44.g67270
>
>
> --
> Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter
> http://www.xs4all.nl/~jantien       | http://www.lilypond.org
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>