git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t4150: remove unused variable

From
Andrei Rybak <rybak.a.v@gmail.com>
Date
Mar 12, 2019, 14:38 UTC
Message-ID
<36ad743f-8429-a6ff-7fad-15e5dba01483@gmail.com>

In commit 735285b403 ("am: fix signoff when other trailers are present", 2017-08-08) tests using variable $signoff were rewritten and it is no longer used, so just remove it from the test setup.

Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
---
 t/t4150-am.sh | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/t/t4150-am.sh b/t/t4150-am.sh
index 55b577d919..3f7f750cc8 100755
--- a/t/t4150-am.sh
+++ b/t/t4150-am.sh
@@ -77,14 +77,12 @@ test_expect_success 'setup: messages' '
 
 	printf "Subject: " >subject-prefix &&
 
-	cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF &&
+	cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF
 	This line should not be included in the commit message with --scissors enabled.
 
 	 - - >8 - - remove everything above this line - - >8 - -
 
 	EOF
-
-	signoff="Signed-off-by: $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL>"
 '
 
 test_expect_success setup '
-- 
2.20.1
Next: Junio C Hamano
Message 1 of 3 in “t4150: remove unused variable”
  1. t4150: remove unused variableAndrei Rybak, Mar 12, 2019
  2. Junio C HamanoMar 13, 2019
  3. Phillip WoodMar 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.