[PATCH v2 2/2] t9700: do not close STDERR
- From
Thomas Rast <trast@inf.ethz.ch>
- Date
- Apr 4, 2013, 20:41 UTC
- Message-ID
- <3689abc8e1af4ddbbb7791dd6241996f86e4efa2.1365107899.git.trast@inf.ethz.ch>
- In-Reply-To
- <20130404011653.GA28492@dcvr.yhbt.net>
Much like the previous patch, this triggered an unrelated bug. Closing STDERR is not worth it anyway, as we risk writing die() and such to random files that happen to be subsequently opened on FD 2. Don't do it.
Signed-off-by: Thomas Rast <trast@inf.ethz.ch> --- t/t9700/test.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t9700/test.pl b/t/t9700/test.pl index 0d4e366..1140767 100755 --- a/t/t9700/test.pl +++ b/t/t9700/test.pl @@ -45,7 +45,8 @@ is($r->get_color("color.test.slot1", "red"), $ansi_green, "get_color"); # Failure cases for config: # Save and restore STDERR; we will probably extract this into a # "dies_ok" method and possibly move the STDERR handling to Git.pm. -open our $tmpstderr, ">&STDERR" or die "cannot save STDERR"; close STDERR; +open our $tmpstderr, ">&STDERR" or die "cannot save STDERR"; +open STDERR, ">", "/dev/null" or die "cannot redirect STDERR to /dev/null"; is($r->config("test.dupstring"), "value2", "config: multivar"); eval { $r->config_bool("test.boolother") }; ok($@, "config_bool: non-boolean values fail");
-- 1.8.2.607.g19d29d3