RE: [JGIT PATCH v3] Replace inefficient new String(String) constructor to silence FindBugs

> FindBugs keeps reporting that our usage of new String(String)
> is not the most efficient way to construct a string.
> 
> http://thread.gmane.org/gmane.comp.version-
> control.git/113739/focus=113787
> > I had a specific reason for forcing a new String object here.
> >
> > The line in question, p, is from the packed-refs file and
> > contains the entire SHA-1 in hex form at the beginning of it.
> > We've converted that into binary as an ObjectId, it uses 1/4 the
> > space of the string portion.
> >
> > The Ref object, its ObjectId, and its name string, are going to be
> > cached in a Map, probably long-term.  We're better off shedding the
> > 80 bytes of memory used to hold the hex SHA-1 then risk substring()
> > deciding its "faster" to reuse the char[] then to make a copy of it.
> 
> Another way to force this new unique String instance with its own
> private char[] is to use a StringBuilder and append onto it the
> ref name.  This shouldn't be a warning for FindBugs, but it would
> accomplish the same goal of producing 1 clean copy, with no extra
> transient temporary array.
> 
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
> CC: Yann Simon <yann.simon.fr@gmail.com>
> CC: Matthias Sohn <matthias.sohn@sap.com>
> ---
> 
>  A less ugly version ?