git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Documentation: specify base point when generating MyFirstContribution patchset

From
Bagas Sanjaya <bagasdotme@gmail.com>
Date
Oct 16, 2021, 05:16 UTC
Message-ID
<35ccb414-c0fe-ab3a-21aa-ac7b1338df6a@gmail.com>
In-Reply-To
<kl6l4k9i1ame.fsf@chooglen-macbookpro.roam.corp.google.com>
On 16/10/21 00.06, Glen Choo wrote:
Show 33 quoted lines
> This reads quite awkwardly because a few lines above, we already tell
> the reader exactly what commands to run:
> 
>    Sending emails with Git is a two-part process; before you can prepare the emails
>    themselves, you'll need to prepare the patches. Luckily, this is pretty simple:
> 
>    ----
>    $ git format-patch --cover-letter -o psuh/ master..psuh
>    ----
> 
> If we do accept this suggestion (and I am not sure if we should, because
> as Junio said, there are strong conventions for determining the branch
> point), I think this would be easier to follow if we incorporate it into
> the existing instructions. Something like..
> 
>    Sending emails with Git is a two-part process; before you can prepare the emails
>    themselves, you'll need to prepare the patches. Luckily, this is
>    pretty simple. First, we'll get the hash of the commit the patchset is
>    based on. We call this commit the 'base'.
> 
>    ----
>    $ git show -s --format="%H" master
>    ----
> 
>    Now, we'll generate the patches, passing the hash of the 'base' to the
>    --base option.
> 
>    ----
>    $ git format-patch --cover-letter --base=<base> -o psuh/ master..psuh
>    ----
> 
>    [...describe --base=<base> the way we describe the other options].
> 

Actually it is up to contributors whether they want to include `--base` or not.

-- 
An old man doll... just what I always wanted! - Clara
Previous: Glen ChooNext: Junio C Hamano
Message 3 of 4 in “Documentation: specify base point when generating MyFirstContribution patchset”
  1. Documentation: specify base point when generating MyFirstContribution patchsetBagas Sanjaya, Oct 15, 2021
  2. Glen ChooOct 15, 2021
  3. Bagas SanjayaOct 16, 2021
  4. Junio C HamanoOct 15, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.