git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/6] t5326: demonstrate potential bitmap corruption

From
Derrick Stolee <derrickstolee@github.com>
Date
Aug 22, 2022, 16:09 UTC
Message-ID
<3525f8bd-31af-181d-b7a5-6e8a453bbba7@github.com>
In-Reply-To
<3e30ab1a19115107fc24a25118f2417319bd1b0d.1660944574.git.me@ttaylorr.com>
On 8/19/2022 5:30 PM, Taylor Blau wrote:
> +test_expect_success 'preferred pack change with existing MIDX bitmap' '
> +	rm -fr repo &&
Does a previous test not delete 'repo' when necessary?

Or, do previous tests re-use 'repo' and now we are in a region where we can safely clear that directory? Should we use a different name?

> +	git init repo &&
> +	test_when_finished "rm -fr repo" &&
nit: test_when_finished should be the first line of the test.
Show 9 quoted lines
> +		# Generate a new MIDX which changes the preferred pack to a pack
> +		# contained in the existing MIDX, such that not all objects from
> +		# p2 that appear in the MIDX had their copy selected from p2.
> +		git multi-pack-index write --bitmap \
> +			--preferred-pack="pack-$p2.pack" &&
> +		test_path_is_file $midx &&
> +		test_path_is_file $midx-$(midx_checksum $objdir).bitmap &&
> +
> +		test_must_fail git clone --no-local . clone2

This section is demonstrating the bug. Perhaps we should have comments indicating that this is not desired behavior, but is being demonstrated so the bug can be fixed by a later change?

Thanks, -Stolee

Previous: Abhradeep ChakrabortyNext: Derrick Stolee
Message 10 of 29 in “midx: permit changing the preferred pack when reusing the MIDX”
  1. 0/6 midx: permit changing the preferred pack when reusing the MIDXTaylor Blau, Aug 19, 2022
  2. 1/6 t5326: demonstrate potential bitmap corruptionTaylor Blau, Aug 19, 2022
  3. 2/6 t/lib-bitmap.sh: avoid silencing stderrTaylor Blau, Aug 19, 2022
  4. 3/6 midx.c: extract `struct midx_fanout`Taylor Blau, Aug 19, 2022
  5. 4/6 midx.c: extract `midx_fanout_add_midx_fanout()`Taylor Blau, Aug 19, 2022
  6. 5/6 midx.c: extract `midx_fanout_add_pack_fanout()`Taylor Blau, Aug 19, 2022
  7. 6/6 midx.c: include preferred pack correctly with existing MIDXTaylor Blau, Aug 19, 2022
  8. Abhradeep ChakrabortyAug 20, 2022
  9. Abhradeep ChakrabortyAug 20, 2022
  10. Derrick StoleeAug 22, 2022
  11. Derrick StoleeAug 22, 2022
  12. Derrick StoleeAug 22, 2022
  13. Taylor BlauAug 22, 2022
  14. Taylor BlauAug 22, 2022
  15. Taylor BlauAug 22, 2022
  16. Taylor BlauAug 22, 2022
  17. Junio C HamanoAug 22, 2022
  18. Taylor BlauAug 22, 2022
  19. Taylor BlauAug 22, 2022
  20. 0/7 midx: permit changing the preferred pack when reusing the MIDXTaylor Blau, Aug 22, 2022
  21. 1/7 t5326: demonstrate potential bitmap corruptionTaylor Blau, Aug 22, 2022
  22. 2/7 t/lib-bitmap.sh: avoid silencing stderrTaylor Blau, Aug 22, 2022
  23. 3/7 midx.c: extract `struct midx_fanout`Taylor Blau, Aug 22, 2022
  24. 4/7 midx.c: extract `midx_fanout_add_midx_fanout()`Taylor Blau, Aug 22, 2022
  25. 5/7 midx.c: extract `midx_fanout_add_pack_fanout()`Taylor Blau, Aug 22, 2022
  26. 7/7 midx.c: avoid adding preferred objects twiceTaylor Blau, Aug 22, 2022
  27. 6/7 midx.c: include preferred pack correctly with existing MIDXTaylor Blau, Aug 22, 2022
  28. Derrick StoleeAug 23, 2022
  29. Derrick StoleeAug 23, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.