Re: What's cooking in git.git (Sep 2024, #08; Fri, 20)
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Sep 23, 2024, 01:31 UTC
- Message-ID
- <34346998-deac-4e1f-9d5f-218f664e9e08@gmail.com>
- In-Reply-To
- <xmqqed5ddexk.fsf@gitster.g>
On 9/20/24 8:32 PM, Junio C Hamano wrote:
> * ds/pack-name-hash-tweak (2024-09-19) 6 commits > - test-tool: add helper for name-hash values > - p5313: add size comparison test > - git-repack: update usage to match docs > - pack-objects: add GIT_TEST_FULL_NAME_HASH > - repack: test --full-name-hash option > - pack-objects: add --full-name-hash option > > In a repository with too many (more than --window size) similarly > named files, "git repack" would not find good delta-base candidate > and worse, it may not use a blob from exactly the same path as a > good delta-base candidate. Optionally replace the name hash so > that only blobs at the same path and nothing else are used as > delta-base candidate. > > Will merge to 'next'? > source: <pull.1785.v2.git.1726692381.gitgitgadget@gmail.com>
There was some speculation [1] that maybe this --full-name-hash option would be considered redundant or irrelevant when the --path-walk feature is submitted/reviewed/merged. I'm not sure that that is the case, but maybe we should leave this open a bit longer for folks to weigh in on it?
[1] https://lore.kernel.org/git/81bc5d69-cf50-409d-ac64-5b9b3f722ace@app.fastmail.com/T/#me45c4fd489bae987785cddb9580339095095fa9e
Thanks, -Stolee