git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t-example-decorate: remove test messages

From
René Scharfe <l.s.r@web.de>
Date
Jul 31, 2024, 09:21 UTC
Message-ID
<333d0d04-5fe6-4fca-8cce-1bb557740a70@web.de>
In-Reply-To
<D33CBWZJZSRS.1V3U16NM91BOA@gmail.com>
Am 31.07.24 um 03:41 schrieb Ghanshyam Thakkar:
Show 10 quoted lines
>
> If we want to further simplify, I don't see any need for having 'ret'
> either and to just call the methods in check():
>
>     check(add_decoration(&vars->n, vars->two, NULL), ==, NULL);
>
> which would also provide more context in the stdout rather than printing
> 'check(ret == NULL)'. But, I believe you would have already considered
> that but kept 'ret' in favor of code readability, so I am also fine with
> it. Thanks for patch.
Good idea!  Worth a separate patch, though.
René
Previous: Ghanshyam Thakkar
Message 3 of 3 in “t-example-decorate: remove test messages”
  1. t-example-decorate: remove test messagesRené Scharfe, Jul 30, 2024
  2. Ghanshyam ThakkarJul 31, 2024
  3. René ScharfeJul 31, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.