[PATCH 08/24] clone: --bundle-uri cannot be combined with --depth
- From
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
- Date
- May 20, 2022, 18:40 UTC
- Message-ID
- <333180f80904a2a0675bfa65fab62107fa13b2a9.1653072042.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.1234.git.1653072042.gitgitgadget@gmail.com>
From: Derrick Stolee <derrickstolee@github.com>
The previous change added the '--bundle-uri' option, but did not check if the --depth parameter was included. Since bundles are not compatible with shallow clones, provide an error message to the user who is attempting this combination.
I am leaving this as its own change, separate from the one that implements '--bundle-uri', because this is more of an advisory for the user. There is nothing wrong with bootstrapping with bundles and then fetching a shallow clone. However, that is likely going to involve too much work for the client _and_ the server. The client will download all of this bundle information containing the full history of the repository only to ignore most of it. The server will get a shallow fetch request, but with a list of haves that might cause a more painful computation of that shallow pack-file.
RFC-TODO: add a test case for this error message.
Signed-off-by: Derrick Stolee <derrickstolee@github.com> --- builtin/clone.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/builtin/clone.c b/builtin/clone.c index fd1ae82e57b..a9caa5dfed6 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -926,6 +926,11 @@ int cmd_clone(int argc, const char **argv, const char *prefix) option_no_checkout = 1; } + if (bundle_uri) { + if (deepen) + die(_("--bundle-uri is incompatible with --depth, --shallow-since, and --shallow-exclude")); + } + repo_name = argv[0]; path = get_repo_path(repo_name, &is_bundle);
-- gitgitgadget