git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Why is there still git-rebase--am.sh?

From
Alban Gruin <alban.gruin@gmail.com>
Date
Jun 2, 2019, 11:04 UTC
Message-ID
<3322453.bNc8J3RWDa@andromeda>
Hi,

I was wandering in rebase’s source code, and found out that even though run_specific_rebase() no longer calls git-rebase--am.sh since 21853626ea ("built-in rebase: call `git am` directly", 2019-01-18), this commit did not remove the code to call it. I guess it was an oversight.

Now that git-legacy-rebase.sh is gone (since d03ebd411c, "rebase: remove the rebase.useBuiltin setting", 2019-03-18), I would expect this file to be completely removed, too.

May I send a patch to remove git-rebase--am.sh, or is there a reason to keep it?

Cheers, Alban

Next: Philip Oakley
Message 1 of 2 in “Why is there still git-rebase--am.sh?”
  1. Alban GruinJun 2, 2019
  2. Philip OakleyJun 2, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.