Re: [PATCH] Use time_t for timestamps returned by approxidate() instead of unsigned

From: Tim Henigan <tim.henigan@gmail.com>
Date: Jan 24, 2009, 17:14 UTC
Message-ID: <32c343770901240914n3fc76fe0vbe844e50cbc0bbf@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0901241757140.13232@racer>

On Sat, Jan 24, 2009 at 11:58 AM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 5 quoted lines

>> Should I update the GitWiki page to remove this Janitor task or do you
>> keep it as a test to see if people are properly searching the mail
>> archives?
>
> Yes, please!

I did some more digging and found this last comment on the subject by Linus: https://kerneltrap.org/mailarchive/git/2008/11/6/4014344

Given this, should the janitor task simply be deleted (since using unsigned longs are safe until year 2038 is considered) or should it be updated to change all timestamps to 64-bit values?

Also, there are still ~37 references to time_t in the code (e.g. the index_state struct in cache.h). Should these be phased out in favor of unsigned longs (or perhaps 64-bit types)?

Perhaps the Janitor task should be changed to do this so that all the code handles timestamps consistently? (btw, I will volunteer to do this if desired).

Thanks, Tim