Re: git-subtree.sh - regression introduced by da949cc55

From: Avery Pennarun <apenwarr@gmail.com>
Date: Feb 12, 2010, 17:52 UTC
Message-ID: <32541b131002120952gcb5116as730fff8bdcf005c1@mail.gmail.com>
In-Reply-To: <508e1531002110526u623bffbdi119d009a7af460b8@mail.gmail.com>

On Thu, Feb 11, 2010 at 8:26 AM, Jakub Suder <jakub.suder@gmail.com> wrote:

Show 15 quoted lines

> On Thu, Feb 11, 2010 at 14:08, Marc Fournier
> <marc.fournier@camptocamp.com> wrote:
>> Jakub, I'm not sure I understand what this patch is supposed to fix. Could
>> you provide an example ? Or a test case ?
>
> there is a test case for the change you're talking about - it's near
> the end of test.sh, between "check if split can find proper base
> without --onto" and "check_equal ..." (it was added a few commits
> later). The problem was that without this commit, in some cases if I
> called subtree split for an external project which was earlier added
> with git subtree (in order to backport some changes to the original
> project) it didn't create the new commits on top of the existing ones
> like it should (just look at the test case).
>
> I'll take a closer look at this in the evening...

Did you have a chance to look at this?

Avery