Re: [PATCH 1/3] urlmatch: normalize ssh and ftp default ports
- From
- Fabian Pottbäcker <fpottbaecker+git@mailbox.org>
- Date
- Jul 28, 2026, 10:51 UTC
- Message-ID
- <32323233-CE82-421A-94D2-5902C4382F8D@mailbox.org>
- In-Reply-To
- <DE62DFBE-ED4C-4EF5-8F4D-FAAB3519F86A@gmail.com>
> On 24. Jul 2026, at 13:35, Ben Knoble <ben.knoble@gmail.com> wrote: > > Just offhand, not commenting on the rest of the series : the comments look wrong for ftp, ssh to me.
Right, I messed up the continuation indent here (I wanted to make it in line with the rest of the file). Lined up for a v2, but it is minor so I would await further comments for now (see https://gitlab.com/fpottbaecker/git/-/compare/config_url_scp_syntax_v1..config_url_scp_syntax).
Also, since I noticed this as a convenience thing gitgitgadget does:
Fetch-It-Via: git fetch https://gitlab.com/fpottbaecker/git.git config_url_scp_syntax_v1