Re: [JGIT PATCH] 1/2 : (reworked) Externalizable/Serializable Items
- From
Nigel Magnay <nigel.magnay@gmail.com>
- Date
- Feb 20, 2009, 09:28 UTC
- Message-ID
- <320075ff0902200128o6b9772a4tcbd652e7654524e@mail.gmail.com>
- In-Reply-To
- <320075ff0902200127m3e516621m60a608bc891ab992@mail.gmail.com>
On Wed, Feb 18, 2009 at 4:30 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
Show 9 quoted lines
>
> Nigel Magnay <nigel.magnay@gmail.com> wrote:
> > +public class ObjectId extends AnyObjectId implements Serializable {
>
> We should define our own serialVersionUID:
>
> private static final long serialVersionUID = 1L;
>
> is good enough to make Java happy.I'll re-roll. Actually both that and the whitespace damage I'm partially blaming on eclipse. Eclipse curiously removes the warning to declare serialVersionUID if you declare both writeObject and readObject - that's wrong!
Also the formatting came from .settings/org.eclipse.core.resources.prefs which has a tab policy of "Tabs only" which has overridden my environment setting of spaces-only.
I can modify it to spaces only - but the comment in 9268ced9d38 talks about spaces-per-tab..?