Re: [PATCH] Teach git submodule update to use distributed repositories

From: Nigel Magnay <nigel.magnay@gmail.com>
Date: Jul 18, 2008, 09:18 UTC
Message-ID: <320075ff0807180218k7cfd4b07l67a1c82af0d61653@mail.gmail.com>
In-Reply-To: <200807181107.18098.jnareb@gmail.com>

On Fri, Jul 18, 2008 at 10:07 AM, Jakub Narebski <jnareb@gmail.com> wrote:

Show 13 quoted lines

> Junio C Hamano wrote:
>
>> [...] It is understandable that you would
>> want to script something that recurses into the submodules that you have
>> checked out (or submodules that Fred wants you to look at), do the
>> equivalent of "git fetch ../fred" you did at the toplevel to automate that
>> step, but I very much agree with Pasky here in that it feels very wrong to
>> hijack "submodule update" for it.
>
> There were two proposals how to deal with fetching all submodules:
> (a) git-submodule recursing into submodules, IIRC even with some
> implementation (b) new "git submodule fetch" command.
>

Yes - I think there's a few more options and possible combinations

a. git submodule update having <repository> <refspec> to recurse into submodules (a)(original patch) b. git submodule fetch c. git fetch --submodules d. git fetch (automatically recurse if there are submodules) e. git fetch (automatically recurse if there is some setting in .git/config)

I started at (a) and agree that it's a bad choice. Any of b-e would work for me. My (personal) preferences would be for d/e, then c, then b - but - that's based on my belief that submodules are a pretty fundamental thing and having a separate UI is bad.