git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] doc: add shortcut to "am --whitespace=<action>"

From
DSDragan Simic <dsimic@manjaro.org>
Date
Feb 14, 2024, 19:20 UTC
Message-ID
<31285decfdd9390cfea5cfdd558dbbed@manjaro.org>
In-Reply-To
<xmqqle7mvp4x.fsf@gitster.g>
On 2024-02-14 20:09, Junio C Hamano wrote:
Show 15 quoted lines
> Dragan Simic <dsimic@manjaro.org> writes:
> 
>>> @@ -128,6 +128,9 @@ include::rerere-options.txt[]
>>>  	These flags are passed to the 'git apply' (see 
>>> linkgit:git-apply[1])
>>>  	program that applies
>>>  	the patch.
>> 
>> It would be nice to, while there, move "the patch." to the line above.
> 
> It belongs to a separate topic.  These files are sources that will
> be line filled by AsciiDoc, so there is no reason to make such a
> change unless the topic of your change were to make the source
> "prettier", which is not the focus of this patch.  Having such a
> change in the same patch will be distracting.

Makes sense, it can become distracting, especially in a short patch like this one. It's better to stick to the patch topic, and leave small cleanups to a separate patch.

Previous: Junio C Hamano
Message 5 of 5 in “doc: add shortcut to "am --whitespace=<action>"”
  1. doc: add shortcut to "am --whitespace=<action>"Junio C Hamano, Feb 14, 2024
  2. Dragan SimicFeb 14, 2024
  3. Dragan SimicFeb 14, 2024
  4. Junio C HamanoFeb 14, 2024
  5. Dragan SimicFeb 14, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.