Re: [PATCH] doc: add shortcut to "am --whitespace=<action>"
- From
- Dragan Simic <dsimic@manjaro.org>
- Date
- Feb 14, 2024, 19:20 UTC
- Message-ID
- <31285decfdd9390cfea5cfdd558dbbed@manjaro.org>
- In-Reply-To
- <xmqqle7mvp4x.fsf@gitster.g>
On 2024-02-14 20:09, Junio C Hamano wrote:
Show 15 quoted lines
> Dragan Simic <dsimic@manjaro.org> writes: > >>> @@ -128,6 +128,9 @@ include::rerere-options.txt[] >>> These flags are passed to the 'git apply' (see >>> linkgit:git-apply[1]) >>> program that applies >>> the patch. >> >> It would be nice to, while there, move "the patch." to the line above. > > It belongs to a separate topic. These files are sources that will > be line filled by AsciiDoc, so there is no reason to make such a > change unless the topic of your change were to make the source > "prettier", which is not the focus of this patch. Having such a > change in the same patch will be distracting.
Makes sense, it can become distracting, especially in a short patch like this one. It's better to stick to the patch topic, and leave small cleanups to a separate patch.