Re: [PATCH] strbuf: add strbuf_add_real_path()

From: René Scharfe <l.s.r@web.de>
Date: Feb 27, 2017, 22:45 UTC
Message-ID: <3063b6fb-02aa-703c-0b56-300109cf054d@web.de>
In-Reply-To: <20170227182217.GC153455@google.com>

Am 27.02.2017 um 19:22 schrieb Brandon Williams:

Show 14 quoted lines

> On 02/25, René Scharfe wrote:
>> +void strbuf_add_real_path(struct strbuf *sb, const char *path)
>> +{
>> +	if (sb->len) {
>> +		struct strbuf resolved = STRBUF_INIT;
>> +		strbuf_realpath(&resolved, path, 1);
>> +		strbuf_addbuf(sb, &resolved);
>> +		strbuf_release(&resolved);
>> +	} else
>> +		strbuf_realpath(sb, path, 1);
>
> I know its not required but I would have braces on the 'else' branch
> since they were needed on the 'if' branch.  But that's up to you and
> your style :)

Personally I'd actually prefer them as well, but the project's style has traditionally been to avoid braces on such trailing single-line branches to save lines. The CodingGuidelines for this topic have been clarified recently, though, and seem to require them now. Interesting.

René