git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 2/4] test-lib: allow testing another git build tree

From
Thomas Rast <trast@student.ethz.ch>
Date
Dec 15, 2011, 10:33 UTC
Message-ID
<3016269.uH93UWUbx5@thomas.inf.ethz.ch>
In-Reply-To
<7vsjkmpm6g.fsf@alter.siamese.dyndns.org>
On Wednesday 14 December 2011 19:07:35 Junio C Hamano wrote:
Show 7 quoted lines
> Thomas Rast <trast@student.ethz.ch> writes:
> > The perf-lib work wants this feature, so we may as well do it for
> > test-lib in general.
> 
> How is this different from what GIT_TEST_INSTALLED already gives us
> (other than "needs more diskspace to keep another source tree fully
> built", that is)?

I was scared away by the note that it would use (among others) perl libs from the current build tree. Upon investigation I also see that the test-* situation is still not satisfactory. Some (like test-chmtime) are used by the tests for a vital task, and if they ever have to be fixed, we would want to use the fixed version in any "test an old git" run. OTOH, others (e.g., test-dump-cache-tree) are linked with the rest of the code and serve to test an otherwise not accessible part of it, and testing an old git should use them from the tested tree.

The disk space argument is moot IMO: for sane perf testing you need the extra build tree anyway because you cannot checkout another version in the current tree. Otherwise the scripts may change and/or disappear from under themselves.

An optimization might be to have the run script only use a single build tree and several install trees. However, while such a built tree takes just over 100MB of space in my tests, everything installed $PREFIX/libexec/git-core is also already 65MB here. So the latter scheme would only amortize itself if you had at least 3 trees tested simultaneously.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 9 in “Performance test framework”
  1. 0/4 Performance test frameworkThomas Rast, Dec 14, 2011
  2. 1/4 Move the user-facing test library to test-lib-functions.shThomas Rast, Dec 14, 2011
  3. 2/4 test-lib: allow testing another git build treeThomas Rast, Dec 14, 2011
  4. Junio C HamanoDec 15, 2011
  5. Thomas RastDec 15, 2011
  6. Junio C HamanoDec 15, 2011
  7. 3/4 Introduce a performance testing frameworkThomas Rast, Dec 14, 2011
  8. Thomas RastDec 14, 2011
  9. 4/4 Add a performance test for git-grepThomas Rast, Dec 14, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.