Re: [PATCH] format-patch: add support for mailmap file

From: Josh Steadmon <steadmon@google.com>
Date: Aug 13, 2024, 22:45 UTC
Message-ID: <2mvexuxcaow45ifnqmrvpn2yz2ecxzazsbo5ui7xaiwwpzt7hr@mvl6ehbrhrp6>
In-Reply-To: <20240813-jk-support-mailmap-git-format-patch-v1-1-1aea690ea5dd@gmail.com>

On 2024.08.13 14:45, Jacob Keller wrote:

Show 14 quoted lines

> From: Jacob Keller <jacob.keller@gmail.com>
> 
> Git has support for a mailmap file which translates author and committer
> names and email addresses to canonical values.
> 
> Git log has log.mailmap, and the associated --mailmap and --use-mailmap
> options.
> 
> Teach git format-patch the format.mailmap and --mailmap options so that
> formatting a patch can also reflect the canonical values from the
> mailmap file.
> 
> Reported-by: Anthony Nguyen <anthony.l.nguyen@intel.com>
> Signed-off-by: Jacob Keller <jacob.keller@gmail.com>

I am not sure I understand the utility here; using mailmap at log time makes sense because these are old, established commits that may have outdated contact information. But when writing patches with format-patch, presumably these are still somewhat WIP patches. Is it not better to just reset the author information before running git-format-patch in this case?

If I've misunderstood the use case, please let me know.