git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/7] merge-ort: some groundwork for further implementation

From
Derrick Stolee <stolee@gmail.com>
Date
Dec 4, 2020, 17:26 UTC
Message-ID
<2ea0aab8-934f-3eaa-e3d0-9ae35a278748@gmail.com>
In-Reply-To
<pull.803.git.1607011187.gitgitgadget@gmail.com>
On 12/3/2020 10:59 AM, Elijah Newren via GitGitGadget wrote:
Show 24 quoted lines
> This series is based on en/merge-ort-impl. This series sets up three future
> patch series (to add recursive merges, three-way content merging, and rename
> detection) for the merge-ort implementation, and allows the future series to
> be submitted, reviewed, and merged in any order. Since those three things
> actually do have some minor dependencies between them, this preparatory
> series is needed to make a few small changes to set things up to allow them
> to be submitted independently. 
> 
> The first six patches are trivial. They should be easy to review, and as a
> bonus you get to find how I mess up even the trivial stuff. ;-) The final
> patch is more substantive and represents one of the big changes between
> merge-recursive and merge-ort -- namely, how notice/warning/conflict
> messages are reported to the user (I possibly should have included it in
> merge-ort-impl, but that series seemed so long already...).
> 
> Elijah Newren (7):
>   merge-ort: add a few includes
>   merge-ort: add a clear_internal_opts helper
>   merge-ort: add a path_conflict field to merge_options_internal
>   merge-ort: add a paths_to_free field to merge_options_internal
>   merge-ort: add function grouping comments
>   merge-ort: add die-not-implemented stub handle_content_merge()
>     function
>   merge-ort: add modify/delete handling and delayed output processing

Coming back to say that I finished reading PATCH 7 and this series looks good overall. Tough to be confident in it when the implementation isn't connected to tests, but the patches do a good job of describing the isolated changes. If there _are_ problems, it will be easy to identify the reasoning behind the code using log/blame.

Thanks, -Stolee

Previous: Elijah Newren via GitGitGadgetNext: Elijah Newren
Message 12 of 13 in “merge-ort: some groundwork for further implementation”
  1. 0/7 merge-ort: some groundwork for further implementationElijah Newren via GitGitGadget, Dec 3, 2020
  2. 3/7 merge-ort: add a path_conflict field to merge_options_internalElijah Newren via GitGitGadget, Dec 3, 2020
  3. 2/7 merge-ort: add a clear_internal_opts helperElijah Newren via GitGitGadget, Dec 3, 2020
  4. Derrick StoleeDec 3, 2020
  5. 4/7 merge-ort: add a paths_to_free field to merge_options_internalElijah Newren via GitGitGadget, Dec 3, 2020
  6. 5/7 merge-ort: add function grouping commentsElijah Newren via GitGitGadget, Dec 3, 2020
  7. 1/7 merge-ort: add a few includesElijah Newren via GitGitGadget, Dec 3, 2020
  8. 6/7 merge-ort: add die-not-implemented stub handle_content_merge() functionElijah Newren via GitGitGadget, Dec 3, 2020
  9. Derrick StoleeDec 3, 2020
  10. Elijah NewrenDec 3, 2020
  11. 7/7 merge-ort: add modify/delete handling and delayed output processingElijah Newren via GitGitGadget, Dec 3, 2020
  12. Derrick StoleeDec 4, 2020
  13. Elijah NewrenDec 4, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.