Re: [PATCH] setup: recognize bare repositories with packed-refs
- From
Adam Majer <adamm@zombino.com>
- Date
- Nov 28, 2023, 14:14 UTC
- Message-ID
- <2e5e3225-6e94-43ff-ab7b-18aed2048372@zombino.com>
- In-Reply-To
- <ZWTxuBV1DGieo6n2@google.com>
On 11/27/23 20:44, Josh Steadmon wrote:> Two suggestions for the test here:
> 1) Can you give the test a more descriptive name, such as "GCed bare > repos still recognized"?
Thanks, adjusted. I've also added that empty refs/ directory is not there.
> 2) Can you add a check that bare.git/packed-refs exists?
Done.
I've also removed the -C parameter since we actually need GIT_DIR= in all cases to prevent git from going up directory tree. -C is then superflous. In addition, I've changed the hardcoded object id to master branch to make it less magical looking.
- Adam