Re: [PATCH] Documentation: update description of shell aliases

From: Sitaram Chamarty <sitaramc@gmail.com>
Date: Jul 2, 2009, 00:57 UTC
Message-ID: <2e24e5b90907011757r498b8c52v4cf5dfb7016bf8b5@mail.gmail.com>
In-Reply-To: <7v7hysl0x8.fsf@alter.siamese.dyndns.org>

On Wed, Jul 1, 2009 at 11:51 PM, Junio C Hamano<gitster@pobox.com> wrote:

Show 7 quoted lines

> Sitaram Chamarty <sitaramc@gmail.com> writes:
>
>> Aliases that invoke shell commands start from the top-level directory,
>> but this was not documented.
>
> Could you please also think if it is worth mentioning what happens when
> you do not even have a top-level directory?  I.e. in a bare repository.

Yes I thought about it. I decided not to add that because it is:

  - not common enough (how many new users fiddle in bare
    repos?)

  - not surprising enough (I did test it; it just uses the
    current -- bare -- directory, as even a new user would
    expect)

(In contrast, the part I added _was_ somewhat surprising.)

And if we go that far, why not also document what happens with various combinations of $PWD,$GIT_DIR and $GIT_WORK_TREE? I did not get a chance to test those, but if you think we should add those also, I will do so and document what happens.

I just think it may be a bit overkill, but if you think it's not, and it adds value, just say so and I will test and document it.