git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t3008: find test-tool through path lookup

From
Johannes Sixt <j6t@kdbg.org>
Date
Dec 22, 2019, 15:03 UTC
Message-ID
<2dc0b0f3-19ce-62ab-5af9-fdb2d05b00bd@kdbg.org>

Do not use $GIT_BUILD_DIR without quotes; it may contain spaces and be split into fields. But it is not necessary to access test-tool with an absolute path in the first place as it can be found via path lookup. Remove the explicit path.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 Found this today coincidentally when I happened to look at the terminal
 with test output at the right time and saw a suspicous error message
 that included just one half of the build directory path.
 -- Hannes
 t/t3008-ls-files-lazy-init-name-hash.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t3008-ls-files-lazy-init-name-hash.sh b/t/t3008-ls-files-lazy-init-name-hash.sh
index 64f047332b..85f3704958 100755
--- a/t/t3008-ls-files-lazy-init-name-hash.sh
+++ b/t/t3008-ls-files-lazy-init-name-hash.sh
@@ -4,7 +4,7 @@ test_description='Test the lazy init name hash with various folder structures'
 
 . ./test-lib.sh
 
-if test 1 -eq $($GIT_BUILD_DIR/t/helper/test-tool online-cpus)
+if test 1 -eq $(test-tool online-cpus)
 then
 	skip_all='skipping lazy-init tests, single cpu'
 	test_done
-- 
2.24.1.524.gae569673ff
Next: Johannes Schindelin
Message 1 of 2 in “t3008: find test-tool through path lookup”
  1. t3008: find test-tool through path lookupJohannes Sixt, Dec 22, 2019
  2. Johannes SchindelinJan 1, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.