Re: git grep failure?
- From
- Randy Dunlap <rdunlap@infradead.org>
- Date
- Mar 19, 2026, 04:42 UTC
- Message-ID
- <2c943182-d5d7-4f72-ab97-8d07bf4ed216@infradead.org>
- In-Reply-To
- <20260319003829.GA3530301@coredump.intra.peff.net>
On 3/18/26 5:38 PM, Jeff King wrote:
Show 22 quoted lines
> On Wed, Mar 18, 2026 at 04:28:17PM -0700, Randy Dunlap wrote:
>
>> If I apply the patch at
>> https://lore.kernel.org/linux-doc/c5bb61cf789df1ecb32facc29df9749987c7ddfc.1773346620.git.ljs@kernel.org/
>>
>> Subject: [PATCH 02/15] mm: add documentation for the mmap_prepare file operation callback
>>
>> to the Linux kernel tree (e.g., linux-next-20260316), it applies cleanly.
>>
>> I noticed a typo in the patch ("struct vma_area_desc" should be
>> "struct vm_area_desc"). When I run
>> $ git grep vma_area_desc
>> the output is empty.
>>
>> Is this expected? (but not by me :)
>
> I applied the patch and git-grep does produce one line of output (the
> instance added by the patch).
>
> Two possible differences:
>
> - are you sure the patch application succeeded?'git apply filename.patch' succeeded AFAICT. git status shows one untracked file (the one that is added by the patch). Do I need to do 'git commit' also?
Show 8 quoted lines
> - are you in a different subdirectory? By default git-grep narrows its > search to your current working directory and its subdirectories. So > if you are in arch/ or something, it would not find the result in > Documentation/. You can do: > > git grep vma_area_desc :/ > > to search from the root of the project.
I'm running 'git grep' from the top-level directory of the kernel source tree.
thanks.
-- ~Randy