Re: [PATCH] shortlog: initialize nongit variable

From: Jonas Fonseca <jonas.fonseca@gmail.com>
Date: Mar 25, 2008, 19:58 UTC
Message-ID: <2c6b72b30803251258j313e0d94qe290b8b7c7b377f0@mail.gmail.com>
In-Reply-To: <20080325160356.GC6506@neumann>

2008/3/25 SZEDER Gábor <szeder@ira.uka.de>:

>  However, it might be better to let setup_git_directory_gently() set
>  *nongit_ok to 0 if we are in a git repository.  Patch appended.

As the one responsible for introducing this bug into shortlog, I can only agree.

Show 7 quoted lines

>   builtin-bundle.c     |    2 +-
>   builtin-config.c     |    2 +-
>   builtin-diff-files.c |    2 +-
>   builtin-ls-remote.c  |    2 +-
>   git.c                |    2 +-
>   setup.c              |    8 ++++++++
>   6 files changed, 13 insertions(+), 5 deletions(-)

git grep reveals that builtin-{apply,diff}.c, help.c and var.c also belongs on this list.

-- 
Jonas Fonseca