Re: [PATCH 3/4] builtin/repack.c: write cruft packs to arbitrary locations

From: Derrick Stolee <derrickstolee@github.com>
Date: Nov 7, 2022, 19:32 UTC
Message-ID: <2c59cbca-05fb-8aef-a671-61b4a463a368@github.com>
In-Reply-To: <c0f4ec92a057fdab905447bb917ff09e9bcaaab3.1666636974.git.me@ttaylorr.com>

On 10/24/22 2:43 PM, Taylor Blau wrote:

Show 6 quoted lines

> @@ -714,7 +717,12 @@ static int write_cruft_pack(const struct pack_objects_args *args,
>  		if (line.len != the_hash_algo->hexsz)
>  			die(_("repack: Expecting full hex object ID lines only "
>  			      "from pack-objects."));
> -		string_list_append(names, line.buf);
> +                /*

This line looked oddly out-of-alignment with the next one.

It seems that the comment is preceded by spaces and not tabs. Perhaps Junio fixed this during his application of the patch to keep the builds happy.

Show 5 quoted lines

> +		 * avoid putting packs written outside of the repository in the
> +		 * list of names
> +		 */
> +		if (local)
> +			string_list_append(names, line.buf);

LGTM.

Thanks, -Stolee