[PATCH resend] commit: avoid parent list buildup in clear_commit_marks_many()
- From
René Scharfe <l.s.r@web.de>
- Date
- Feb 23, 2025, 08:26 UTC
- Message-ID
- <2bd2d71f-0ee6-405f-bec8-368406ca53c8@web.de>
- In-Reply-To
- <16a7b572-0a3d-4707-9034-0dac69ea99ac@web.de>
clear_commit_marks_1() clears the marks of the first parent and its first parent and so on, and saves the higher numbered parents in a list for later. There is no benefit in keeping that list growing with each handled commit. Clear it after each run to reduce peak memory usage.
Signed-off-by: René Scharfe <l.s.r@web.de> --- commit.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/commit.c b/commit.c index 540660359d..6efdb03997 100644 --- a/commit.c +++ b/commit.c @@ -780,14 +780,14 @@ static void clear_commit_marks_1(struct commit_list **plist, void clear_commit_marks_many(size_t nr, struct commit **commit, unsigned int mark) { - struct commit_list *list = NULL; - for (size_t i = 0; i < nr; i++) { + struct commit_list *list = NULL; + clear_commit_marks_1(&list, *commit, mark); + while (list) + clear_commit_marks_1(&list, pop_commit(&list), mark); commit++; } - while (list) - clear_commit_marks_1(&list, pop_commit(&list), mark); } void clear_commit_marks(struct commit *commit, unsigned int mark) -- 2.48.1