Re: [PATCH] Makefile(s): avoid recipe prefix in conditional statements

From: Paul Smith <psmith@gnu.org>
Date: Apr 9, 2024, 20:41 UTC
Message-ID: <2b392b30614abd9a110515448853aa43eac42d8b.camel@gnu.org>
In-Reply-To: <xmqqh6gb5szm.fsf@gitster.g>

On Mon, 2024-04-08 at 16:34 -0700, Junio C Hamano wrote:

Show 5 quoted lines

> I am not sure what benefits are gained by the existing users with
> this change to ease fixing some parser bug (I didn't bother to see
> your bug tracker) so I cannot judge if the benefit outweighs the
> cost of them all having to scramble and adjust to the new world
> order.

Just to point out that it's actually unusual (in my experience) for makefiles to use TAB as indentation. There are so many situations where this comes back to bite you (see my other emails) that people simply don't do it.

I realize Git and Linux (using Linus's coding style) are committed to each-TAB-is-one-indentation-level, even insofar as using it inside makefiles not just C code, but they are outliers IME.

So I'm not sure I'm ready to concede (yet) that the "cost of them all" is actually very wide. Certainly two projects as popular as Git and Linux with this problem are very concerning.