[PATCH v5 2/2] name-rev.c: use strbuf_getline instead of limited size buffer

From

John Cai via GitGitGadget <gitgitgadget@gmail.com>

Date

Jan 5, 2022, 04:20 UTC

Message-ID

<2acd70f36e73fe47261fc7b2f86dcdfc10580d82.1641356439.git.gitgitgadget@gmail.com>

In-Reply-To

<pull.1171.v5.git.git.1641356439.gitgitgadget@gmail.com>

From: John Cai <johncai86@gmail.com>

Signed-off-by: "John Cai" <johncai86@gmail.com>
---
 builtin/name-rev.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/builtin/name-rev.c b/builtin/name-rev.c
index 21370afdaf9..d16b4ca0b66 100644
--- a/builtin/name-rev.c
+++ b/builtin/name-rev.c
@@ -625,12 +625,11 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix)
 	if (annotate_stdin) {
 		struct strbuf sb = STRBUF_INIT;
 
-		while (!feof(stdin)) {
-			char *p = fgets(buffer, sizeof(buffer), stdin);
-			if (!p)
-				break;
-			name_rev_line(p, &data);
+		while (strbuf_getline(&sb, stdin) != EOF) {
+			strbuf_addch(&sb, '\n');
+			name_rev_line(sb.buf, &data);
 		}
+		strbuf_release(&sb);
 	} else if (all) {
 		int i, max;
 

-- 
gitgitgadget