git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/2] git-gui: Add support of SHA256 repo

From
Johannes Sixt <j6t@kdbg.org>
Date
Jul 16, 2025, 17:38 UTC
Message-ID
<2a7f20ef-ad7b-47b5-9c3a-71fbdd11e756@kdbg.org>
In-Reply-To
<20250716073227.11486-1-tiwai@suse.de>
Am 16.07.25 um 09:32 schrieb Takashi Iwai:
> Here is the v3 patch for git-gui to support SHA256 repos.
> I put a preliminary patch to clean up $null_sha1 in addition to the
> correction / update of v2 patch.
Thanks, queued.

I applied the following fixups: an obvious typo-fix in a comment and use of our wrapper function `git` instead of plain Tcl `exec git`.

diff --git a/git-gui.sh b/git-gui.sh
index c437980927fd..523e4df8069a 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -1298,8 +1298,8 @@ if {[catch {
 	set picked 1
 }
 
-# Use object format as hash algorightm (either "sha1" or "sha256")
-set hashalgorithm [exec git rev-parse --show-object-format]
+# Use object format as hash algorithm (either "sha1" or "sha256")
+set hashalgorithm [git rev-parse --show-object-format]
 if {$hashalgorithm eq "sha1"} {
 	set hashlength 40
 } elseif {$hashalgorithm eq "sha256"} {
Previous: Takashi IwaiNext: Takashi Iwai
Message 4 of 5 in “git-gui: Add support of SHA256 repo”
  1. 0/2 git-gui: Add support of SHA256 repoTakashi Iwai, Jul 16, 2025
  2. 1/2 git-gui: Replace null_sha1 with nullidTakashi Iwai, Jul 16, 2025
  3. 2/2 git-gui: Add support of SHA256 repoTakashi Iwai, Jul 16, 2025
  4. Johannes SixtJul 16, 2025
  5. Takashi IwaiJul 17, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.