git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] revision.c: use proper data type in call to sizeof() within xrealloc

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Nov 13, 2008, 20:20 UTC
Message-ID
<2NXgsahhUCpkej6JukLNJjebzyoAQgZ4ptQMMrR2j_iWS5yEqKYn0kxHsUBpiY6bkpfbTjxlSn0@cipher.nrlssc.navy.mil>

A type char** was being used instead of char*. ---

Just a little typo, that doesn't make any difference but should be fixed.
-brandon
 revision.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/revision.c b/revision.c
index 2f646de..440d152 100644
--- a/revision.c
+++ b/revision.c
@@ -968,7 +968,7 @@ static void add_ignore_packed(struct rev_info *revs, const char *name)
 	int num = ++revs->num_ignore_packed;
 
 	revs->ignore_packed = xrealloc(revs->ignore_packed,
-				       sizeof(const char **) * (num + 1));
+				       sizeof(const char *) * (num + 1));
 	revs->ignore_packed[num-1] = name;
 	revs->ignore_packed[num] = NULL;
 }
-- 
1.6.0.3.552.g12334
Next: Jeff King
Message 1 of 2 in “revision.c: use proper data type in call to sizeof() within xrealloc”
  1. revision.c: use proper data type in call to sizeof() within xreallocBrandon Casey, Nov 13, 2008
  2. Jeff KingNov 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.