Re: [PATCH] Remove perl dependant commands if NO_PERL is set
- From
Renato Botelho <garga@freebsd.org>
- Date
- Sep 3, 2015, 19:39 UTC
- Message-ID
- <2CFFD89E-7059-4C1C-B715-15C5F6C2D295@FreeBSD.org>
- In-Reply-To
- <xmqq7fo7jp1e.fsf@gitster.mtv.corp.google.com>
Show 18 quoted lines
> On Sep 3, 2015, at 16:11, Junio C Hamano <gitster@pobox.com> wrote: > > garga@FreeBSD.org writes: > >> From: Renato Botelho <garga@FreeBSD.org> >> >> git-submodule and git-request-pull are written in sh but use perl >> internally. Add them to be replaced by unimplemented.sh when NO_PERL >> flag is set >> --- > > Missing sign-off. > > You also may want to hold off the "git-submodule" bit, as I expect > http://thread.gmane.org/gmane.comp.version-control.git/277128/focus=277129 > would be one of the first changes to be in 'master' after the > upcoming release 2.6 (that is, it is likely that perl dependency > would be removed in 2.7).
Can’t we add git-submodule to the list now, for 2.6, and then remove it when this change is pushed? This would help to have a sane tarball for 2.6. I’m considering this from a package maintainer perspective.
I’ll re-send it with sign-off. -- Renato Botelho