Re: [PATCH] Make "git stash" configurable

From: Steven Grimm <koreth@midwinter.com>
Date: Dec 21, 2007, 17:23 UTC
Message-ID: <2AB285BD-DA6E-49D1-B664-B1A8B552DD76@midwinter.com>
In-Reply-To: <200712211026.lBLAQWWM014059@mi0.bluebottle.com>

On Dec 21, 2007, at 2:22 AM, しらいしななこ wrote:

> "git stash" without argument originally created an unnamed
> stash, but some people felt this can be confusing to new
> users.  This introduces per-user config variable stash.quick to
> control this behavior.

This whole thing smells of indecision to me. We should figure out a behavior we want and go with it. Git's command line interface is already confusing enough without adding this kind of variability -- any new user is going to look at this and say, "Why couldn't they just make up their minds?"

My vote is to require "save". We already have an alias mechanism that people can use to turn "git stash save" into a two-word command. And I say this as someone who runs "git stash" and will have to retrain his fingers.

-Steve (who thinks "trying to please everyone at all times" is usually a source of bad UI design decisions)