git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] refspec.h: reinstate 'extern' to fix sparse warning

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
May 16, 2018, 21:35 UTC
Message-ID
<29f60a43-9c95-512a-ef85-558906a08ed0@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Brandon,

If you need to re-roll your 'bw/refspec-api' branch, could you please squash this, or the equivalent change before the 'struct refname' to 'struct refname_item' name change, into the relevant patch. (which would be patch #1, commit 8999381ed).

This patch was built on top of 'pu', but as I said above, patch #1 is where the original 'extern' keyword was dropped. (see first hunk of the diff to 'remote.h').

Thanks!

ATB, Ramsay Jones

 refspec.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/refspec.h b/refspec.h
index 374f8ea63..7e1ff94ac 100644
--- a/refspec.h
+++ b/refspec.h
@@ -2,7 +2,7 @@
 #define REFSPEC_H
 
 #define TAG_REFSPEC "refs/tags/*:refs/tags/*"
-const struct refspec_item *tag_refspec;
+extern const struct refspec_item *tag_refspec;
 
 struct refspec_item {
 	unsigned force : 1;
-- 
2.17.0
Next: Brandon Williams
Message 1 of 4 in “refspec.h: reinstate 'extern' to fix sparse warning”
  1. refspec.h: reinstate 'extern' to fix sparse warningRamsay Jones, May 16, 2018
  2. Brandon WilliamsMay 16, 2018
  3. Stefan BellerMay 16, 2018
  4. Johannes SchindelinMay 16, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.