Re: [PATCH v3 0/2] Make git-svn work with gitdir links

From: Philip Oakley <philipoakley@iee.org>
Date: Jan 21, 2013, 20:29 UTC
Message-ID: <2931F4CC43E4406DBB878482C2F0E4F4@PhilipOakley>
In-Reply-To: <kdjip9$4j7$1@ger.gmane.org>

From: "Joachim Schmitz" <jojo@schmitz-digital.de>
Sent: Monday, January 21, 2013 2:19 PM

> Junio C Hamano wrote:
>> Barry Wardell <barry.wardell@gmail.com> writes:

[...]

Show 14 quoted lines

>> Thanks for your persistence ;-) As this is a pretty old topic, I'll
>> give two URLs for people who are interested to view the previous
>> threads:
>>
>>    http://thread.gmane.org/gmane.comp.version-control.git/192133
>>    http://thread.gmane.org/gmane.comp.version-control.git/192127
>>
>> You would want to mark it as test_expect_failure in the first patch
>> and then flip it to text_expect_success in the second patch where
>> you fix the breakage?  Otherwise, after applying the first patch,
>> the testsuite will break needlessly.
>
> I'd just apply them the other way round, 1st fix the problem, 2nd add 
> a test for it

Isn't it a case of, 1st demonstrate the problem with a test, and then 2nd fix the problem.

Those less principled could could simply "fix" a non-existent problem merely to get themselves into the change log, or worse, even if one may fix-test under the hood.

>
> Bye, Jojo

Philip