Re: [PATCH 1/1] Git.pm: add semicolon after catch statement

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 10, 2022, 15:10 UTC
Message-ID: <28orrrr1-444q-6595-po76-3nr67r1pp4p0@tzk.qr>
In-Reply-To: <Y02SHlW1rNQdfCHI@coredump.intra.peff.net>

Hi Peff,

On Mon, 17 Oct 2022, Jeff King wrote:

Show 5 quoted lines

> [... talking about safe.directory ...]
>
> But curiously this still does not pass after your patch, because we seem
> to actually open the repository! I think this is because the C code
> allows an explicit GIT_DIR to override the safe-directory checks.

Yes, I remember that this was something we discussed at some length during the embargo: what to do with the explicitly-specified `GIT_DIR` when verifying the ownership, and my recollection is that we asserted that setting `GIT_DIR` qualifies for "they know what they're doing" (in particular when it is done in a script, not interactively).

Ciao, Dscho