git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[GSoC][PATCH v4 3/5] t0000: use test_line_count instead of wc -l

From
JCJonathan Chang <ttjtftx@gmail.com>
Date
Mar 30, 2019, 14:27 UTC
Message-ID
<28986ed00090df33791a6d53a5292b1bb296eaf5.1553954776.git.ttjtftx@gmail.com>
In-Reply-To
<cover.1553954776.git.ttjtftx@gmail.com>
Signed-off-by: Jonathan Chang <ttjtftx@gmail.com>
---
 t/t0000-basic.sh | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 47666b013e..3de13daabe 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -1136,8 +1136,8 @@ test_expect_success 'git commit-tree omits duplicated parent in a commit' '
 	parent=$(sed -n -e "s/^parent //p" -e "/^author /q" actual | sort -u) &&
 	test "z$commit0" = "z$parent" &&
 	git show --pretty=raw $commit2 >actual &&
-	numparent=$(sed -n -e "s/^parent //p" -e "/^author /q" actual | wc -l) &&
-	test $numparent = 1
+	sed -n -e "s/^parent //p" -e "/^author /q" actual >parents &&
+	test_line_count = 1 parents
 '
 
 test_expect_success 'update-index D/F conflict' '
@@ -1146,8 +1146,7 @@ test_expect_success 'update-index D/F conflict' '
 	mv tmp path2 &&
 	git update-index --add --replace path2 path0/file2 &&
 	git ls-files path0 >actual &&
-	numpath0=$(wc -l <actual) &&
-	test $numpath0 = 1
+	test_line_count = 1 actual
 '
 
 test_expect_success 'very long name in the index handled sanely' '
-- 
2.21.0
Previous: Jonathan ChangNext: Jonathan Chang
Message 4 of 9 in “Avoid using pipes”
  1. Jonathan ChangMar 30, 2019
  2. [GSoC][PATCH v4 1/5] t0000: fix indentationJonathan Chang, Mar 30, 2019
  3. [GSoC][PATCH v4 2/5] t0000: avoid using pipesJonathan Chang, Mar 30, 2019
  4. [GSoC][PATCH v4 3/5] t0000: use test_line_count instead of wc -lJonathan Chang, Mar 30, 2019
  5. [GSoC][PATCH v4 4/5] t0000: use test_cmp instead of "test" builtinJonathan Chang, Mar 30, 2019
  6. Thomas GummererMar 30, 2019
  7. jonathan changMar 31, 2019
  8. Thomas GummererMar 31, 2019
  9. [GSoC][PATCH v4 5/5] t0000: make use of the test_must_be_empty functionJonathan Chang, Mar 30, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.