Re: What's cooking in git.git (Oct 2018, #04; Fri, 19)

From: Johannes Sixt <j6t@kdbg.org>
Date: Oct 19, 2018, 17:55 UTC
Message-ID: <2893a226-cbde-9ca6-fa97-cfc981bd57bd@kdbg.org>
In-Reply-To: <xmqq8t2u1nkh.fsf@gitster-ct.c.googlers.com>

Am 19.10.18 um 08:02 schrieb Junio C Hamano:

Show 6 quoted lines

> * js/diff-notice-has-drive-prefix (2018-10-19) 1 commit
>   - diff: don't attempt to strip prefix from absolute Windows paths
> 
>   "git diff /a/b/c /a/d/f" noticed these are full paths with shared
>   leading prefix "/a", but failed to notice a similar fact about "git
>   diff D:/a/b/c D:/a/d/f", which has been corrected.

This patch isn't about a misdetected leading prefix, but about incorrectly truncated absolute paths. How about:

   Under certain circumstances, "git diff D:/a/b/c D:/a/b/d" on
   Windows would strip initial parts from the paths because they
   were not recognized as absolute, which has been corrected.

>   Want tests.

I've sent v2 with a test.

-- Hannes