Re: [BUG] credential wildcard does not match hostnames containing an underscore

From: Alex Waite <alex@waite.eu>
Date: Oct 12, 2021, 18:00 UTC
Message-ID: <2883c3a9-a44f-4b24-acac-5ed573319d27@www.fastmail.com>
In-Reply-To: <xmqqk0ii3zl6.fsf@gitster.g>

Thanks for the response. :-)

> Hmph, given that hostnames cannot have '_' (cf. RFC1123 2.1 "Host
> Names and Numbers", for example), the third URL seems invalid.  Is
> this even a bug?

That is a fair question, and I do acknowledge that later on in my bug report (where I provide some additional information).

The core issue, IMO, is that git is not consistent with itself. I can write a static rule that will match ("https://test_c.example.com") but cannot write a pattern that will do so.

From a user perspective, a URL containing an underscore in the hostname works for everything else (including all other git operations), but not with pattern matching. It took me a couple hours to figure out /why/, as GIT_TRACE does not provide debugging for how git config rules do (or don't) match patterns.

Specifying in the docs which characters are matched would have helped understand why it was behaving so.

In any case, I felt it was opaque, and was worth sharing.

---Alex