git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH 1/9] mavenizing step 1: moved over the initial poms from Jasons branch Signed-off-by: Mark Struberg <struberg@yahoo.de>

From
Mark Struberg <struberg@yahoo.de>
Date
Sep 30, 2009, 19:51 UTC
Message-ID
<287437.36328.qm@web27806.mail.ukl.yahoo.com>
In-Reply-To
<2c6b72b30909280546l62a6ef9cm21112ca071cdef4c@mail.gmail.com>
Hi Jonas!
answers inside

LieGrue, strub

--- On Mon, 9/28/09, Jonas Fonseca <jonas.fonseca@gmail.com> wrote:
Show 22 quoted lines
> From: Jonas Fonseca <jonas.fonseca@gmail.com>
> Subject: Re: [JGIT PATCH 1/9] mavenizing step 1: moved over the initial poms  from Jasons branch Signed-off-by: Mark Struberg <struberg@yahoo.de>
> To: "Mark Struberg" <struberg@yahoo.de>
> Cc: "Robin Rosenberg" <robin.rosenberg.lists@dewire.com>, git@vger.kernel.org, spearce@spearce.org, "Jason van Zyl" <jvanzyl@sonatype.com>
> Date: Monday, September 28, 2009, 2:46 PM
> On Sat, Sep 26, 2009 at 15:50, Mark
> Struberg <struberg@yahoo.de>
> wrote:
> > Hi Robin!
> >
> > a) Actually git-format-patch only created 0001-0009 so
> there is no 0/9.
> 
> For larger patch series, it is good practice (at least on
> git@vger) to
> provide a "cover letter" (see git-format-patch
> --cover-letter) to give
> reviewers of the patch series an idea of what code is
> touched and for
> you to give additional information, such as the state of
> the patch
> series.
txs 4 pointing this out.
Show 24 quoted lines
> 
> > b) 2/9 is the actual directory structure moving. I
> received it, but since it is pretty large (330k already with
> -M -l0) it might got filtered out?
> > If so then may I ask you to please fetch it from http://github.com/sonatype/JGit branch 'mavenize'? It
> has the same content I sent to the list.
> 
> Some general notes on the patch series. First, I am glad
> you posted it
> to have something to discuss and as I have stated in a
> private mail I
> am glad you are doing this. However, I also think it needs
> a lot more
> polish before being integrated.
> 
> While I understand that you want to credit Jason for doing
> the initial
> probe into fully mavenizing JGit, I now think it is wrong
> to base the
> patch series on his patch. My first impression is that it
> actually
> removes features (by not keeping the JGit specific
> settings), which
> you then try to amend later in the patch series.
I'm not sure what JGit specific settings you speak about?
Show 5 quoted lines
> In terms of making the patch series more manageable for
> you, I think
> the best approach is to start with the patches not relevant
> to the
> mavenizing (renaming PathSuffixTestCase). 
In fact the fix of the PathSuffixTestCase came a few days later after I found the reason why I miss a few tests. This should be fixed in the current master anyway and has not so much todo with the mavenization itself.
Show 12 quoted lines
> After this comespatches
> which only touch pom.xml files. For example, move
> jgit-maven/jgit/pom.xml to the top-level pom.xml, extract
> relevant
> pieces to org.spearce.jgit/pom.xml and
> org.spearce.jgit.test/pom.xml,
> improving the pom.xml`s by adding checkstyle/<scm>
> integration, and
> mavenizing org.spearce.jgit.pgm/. The final and most
> invasive parts
> (renaming/(re)moving code/eclipse files etc) should come
> last!

I had the following in mind: every single commit should be compileable and working. So it's not easily manageable to move the directory structure in one patch and apply all the changes into the poms in another commit. We could for sure squash the later few commits, but I didn't liked to rebase and push since there have been a few forks of the mavenize branch and I hoped I could pull back a few commits from others and later do a rebase -i.
Show 13 quoted lines
> Taking this approach Robin and Spearce can start
> integrating initial
> patces and we can all start testing the "mavenization"
> sooner rather
> than after deciding how to rename things and whether or not
> to remove
> certain files.
> 
> The above is a proposal and if you and other agree that it
> is the
> right approach _and_ you do not feel you have the time
> necessary to
> realize it, I am willing to work on it.
Any help is always welcome :)
Previous: Jonas FonsecaNext: Shawn O. Pearce
Message 5 of 35 in “mavenizing step 1: moved over the initial poms from Jasons branch Signed-off-by: Mark Struberg <struberg@yahoo.de>”
  1. 1/9 mavenizing step 1: moved over the initial poms from Jasons branch Signed-off-by: Mark Struberg <struberg@yahoo.de>Mark Struberg, Sep 23, 2009
  2. Robin RosenbergSep 25, 2009
  3. Mark StrubergSep 26, 2009
  4. Jonas FonsecaSep 28, 2009
  5. Mark StrubergSep 30, 2009
  6. Shawn O. PearceSep 30, 2009
  7. Mark StrubergSep 30, 2009
  8. Jason van ZylSep 30, 2009
  9. Mark StrubergOct 1, 2009
  10. Jason van ZylOct 1, 2009
  11. Jonas FonsecaOct 1, 2009
  12. Douglas CamposOct 1, 2009
  13. 3/9 moving some license files and META-INFMark Struberg, Sep 23, 2009
  14. 4/9 checkin all eclipse project file changesMark Struberg, Sep 23, 2009
  15. 5/9 mavenized org.spearce.jgit.pgmMark Struberg, Sep 23, 2009
  16. 6/9 enable missing test cases and fix jgit executable creationMark Struberg, Sep 23, 2009
  17. 7/9 removing eclipse project filesMark Struberg, Sep 23, 2009
  18. 8/9 renamed the PathSuffixFilter test to JUnit conventions, so it gets executed via maven test.Mark Struberg, Sep 23, 2009
  19. 9/9 Add the <scm> section to the parent pomMark Struberg, Sep 23, 2009
  20. Ferry HubertsSep 24, 2009
  21. Mark StrubergSep 24, 2009
  22. Ferry HubertsSep 24, 2009
  23. Mark StrubergSep 24, 2009
  24. Ferry HubertsSep 24, 2009
  25. Ferry HubertsSep 24, 2009
  26. Robin RosenbergSep 25, 2009
  27. Sohn, MatthiasSep 24, 2009
  28. Mark StrubergSep 24, 2009
  29. Douglas CamposSep 25, 2009
  30. Robin RosenbergSep 25, 2009
  31. Mark StrubergSep 26, 2009
  32. Robin RosenbergSep 27, 2009
  33. Jonas FonsecaSep 28, 2009
  34. Robin RosenbergSep 28, 2009
  35. Robin RosenbergSep 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.