Re: [PATCH] git-gui (MinGW): make use of MSys2's msgfmt

From: Lars Schneider <larsxschneider@gmail.com>
Date: Jul 26, 2017, 16:45 UTC
Message-ID: <276F8090-61B8-4BF2-8D5D-7A6306880701@gmail.com>
In-Reply-To: <8a13544743fd5e6a3b3b5fdb35e02c9c34695e25.1500971399.git.johannes.schindelin@gmx.de>

Show 18 quoted lines

> On 25 Jul 2017, at 10:35, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:
> 
> When Git for Windows was still based on MSys1, we had no gettext, ergo
> no msgfmt, either. Therefore, we introduced a small and simple Tcl
> script to perform the same task.
> 
> However, with MSys2, we no longer need that because we have a proper
> msgfmt executable. Plus, the po2msg.sh script somehow manages to hang
> when run in parallel in Git for Windows' SDK (symptom: the Continuous
> Testing tasks timing out).
> 
> Two reasons to use real msgfmt.exe instead.
> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> 
> 	This hopefully fixes the hangs with the Windows builds triggered
> 	by Travis. It was a tough one to figure out originally, and it is

Awesome :-) Thanks for digging into this problem!

- Lars