Re: [PATCH v1] git-clone.txt: add the --recursive option
- From
Alban Gruin <alban.gruin@gmail.com>
- Date
- Sep 13, 2021, 20:42 UTC
- Message-ID
- <26422bc7-f1d4-4959-ce30-b26d8fe61888@gmail.com>
- In-Reply-To
- <CAPig+cR=HUDgFctXzcigZ062c=QWYfGWUPuT7scc-xU_w3NT1w@mail.gmail.com>
Hi Eric,
Le 13/09/2021 à 21:26, Eric Sunshine a écrit :
Show 19 quoted lines
> On Mon, Sep 13, 2021 at 3:14 PM Alban Gruin <alban.gruin@gmail.com> wrote: >> This adds the --recursive option, an alias of --recurse-submodule, to >> git-clone's manual page. >> >> Signed-off-by: Alban Gruin <alban.gruin@gmail.com> >> --- >> I found this out when a friend told me he could not remember how to >> fetch submodules with git-clone, and when another one suggested >> `--recurse-submodule'. I checked the man page, and I was surprised to >> find out that `--recursive' is not mentionned at all. >> >> I did not modify the synopsis. So, this alias, although shorter than >> the "real" option, would still be somewhat hidden in the man page. > > Considering that the `--recursive` option was intentionally removed > from `git-clone.txt` by bb62e0a99f (clone: teach --recurse-submodules > to optionally take a pathspec, 2017-03-17), it's not clear that this > change helps the situation. >
The patch you mention also hides --recursive from the option array, but that was reverted with 5c387428f1 (parse-options: don't emit "ambiguous option" for aliases, 2019-04-29). The option should be re-hidden, or even removed.
Alban