Re: [PATCH 0/2] fix resize issues on large screens

> Am 08.07.23 um 12:55 schrieb Georg Müller:
>> When opening gitk in a multi-monitor setup with different resolutions,
>> the resize factor causes the first columns of the layout get bigger and
>> bigger while the other columns (author, date in upper pane, file list in
>> lower pane) shrink to a minimum size.
>>
>> The following setup triggers the problem on Fedora 38/Gnome 44:
>> * primary screen 1 has a FHD resolution (1920x1080)
>> * secondary screen 2 has a QHD resolution (2560x1440)
>>
>> Every time gitk opens at screen 2, the resize is triggered and the columns
>> are shifted 1.33x to the right (2560/1920 = 1.33).
>> After multiple rounds of closing/opening gitk, the columns are at their
>> minimum size and the contents are not visible or only a minimum is
>> visible.
>>
>> The following patches are two approaches to fix the problem. Maybe the
>> hard-coded values could be variables, this is a first shot to solve the
>> problem.
>
> Since you haven't stated it explicitly, I assume that with "the problem
> solved" the resizing does not happen anymore. That's fine, but could be
> stated explicitly.
>
> When you say "two approaches", do you mean that the patches are
> independent and either one solves the problem? And only one of them
> should be taken?
>
> I've not read the code changes (because I don't know a lot of Tcl/Tk).
> But I've seen the commit messages of the patches. They are mostly empty.
> This cover letter has a pretty good explanation of the problem. Please
> copy everything that is relevant for each commit to the commit message,
> because the cover letter won't be available in the commit history.
>
> Thanks,
> -- Hannes

>>
>> Georg Müller (2):
>>    gitk: limit factor scaling on resize to widths below 1900px
>>    gitk: keep author and date colums to a minimal width on resize
>>
>>   gitk-git/gitk | 24 ++++++++++++++++++++++--
>>   1 file changed, 22 insertions(+), 2 deletions(-)
>>
>> --
>> 2.41.0
>>
>>
>