Re: [PATCH] whitespace: fix initial-indent checking

From: Wincent Colaiuta <win@wincent.com>
Date: Dec 16, 2007, 10:00 UTC
Message-ID: <25FDB05F-3E85-4E08-90BE-1BE468C07805@wincent.com>
In-Reply-To: <fk2pua$b4p$1@ger.gmane.org>

El 16/12/2007, a las 10:08, Jakub Narebski escribió:

Show 13 quoted lines

> J. Bruce Fields wrote:
>
>> This allows catching initial indents like '\t        ' (a tab  
>> followed
>> by 8 spaces), while previously indent-with-non-tab caught only  
>> indents
>> that consisted entirely of spaces.
>
> I prefer to use tabs for indent, but _spaces_ for align. While  
> previous,
> less strict version of check catches indent using spaces, this one  
> also
> catches _align_ using spaces.

I'd say that Jakub's is a fairly common use case (it's used in many places in the Git codebase too, I think) so it would be a bad thing to change the behaviour of "indent-with-non-tab".

If you also want to check for "align-with-non-tab" then it really should be a separate, optional class of whitespace error.

Cheers, Wincent