Re: [PATCH] Documentation/git-gc.txt: change --aggressive description
- From
- Pieter de Bie <pieter@frim.nl>
- Date
- May 24, 2008, 19:03 UTC
- Message-ID
- <25B3A6F3-5650-438D-807F-983C811084CC@frim.nl>
- In-Reply-To
- <FCA89971-FDBB-4E44-82CE-C0AA854A4667@ai.rug.nl>
On May 14, 2008, at 8:48 AM, Pieter de Bie wrote:
Show 20 quoted lines
> On 13 mei 2008, at 13:52, Johannes Schindelin wrote: >>> The documentation for the --aggressive flag was misleading, >>> hinting that >>> running git gc with --aggressive is a good thing. However, -- >>> aggressive >>> only really makes sense if you have a bad pack file, such as from >>> git-fast-import. >> >> I disagree. It makes sense to "git gc --aggressive" also after >> cloning >> from somebody who did not do so. > > The problem with this is that your pack might increase in size, > which you can't know in advance. Running "git gc --aggressive" on > the git repo for example increases its size from 20MB to 30MB. > > The current wording at least makes it sound as if --aggressive will > always result in a smaller pack, which is simply not true. > Increasing the window and depth might help, but 250 or even 100 can > be too much on any decently size repository.
Any other comments on this patch? I still think it is an improvement over what is currently in the the man-page.
- Pieter