git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2 2/3] lib-rebase: Allow comments and blank lines to be added to the rebase script

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Jan 12, 2010, 15:38 UTC
Message-ID
<253943b83514372775e375575bba9d7de33c0b28.1263310175.git.mhagger@alum.mit.edu>
In-Reply-To
<7vr5pw3pwp.fsf@alter.siamese.dyndns.org>

(For testing "rebase -i"): Support new action types in $FAKE_LINES to allow comments and blank lines to be added to the "rebase -i" command list.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 t/lib-rebase.sh |   21 ++++++++++++++++-----
 1 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/t/lib-rebase.sh b/t/lib-rebase.sh
index 0fce595..0db8250 100644
--- a/t/lib-rebase.sh
+++ b/t/lib-rebase.sh
@@ -5,13 +5,20 @@
 # - override the commit message with $FAKE_COMMIT_MESSAGE,
 # - amend the commit message with $FAKE_COMMIT_AMEND
 # - check that non-commit messages have a certain line count with $EXPECT_COUNT
-# - rewrite a rebase -i script with $FAKE_LINES in the form
+# - rewrite a rebase -i script as directed by $FAKE_LINES.
+#   $FAKE_LINES consists of a sequence of words separated by spaces.
+#   The following word combinations are possible:
 #
-#	"[<lineno1>] [<lineno2>]..."
+#   "<lineno>" -- add a "pick" line with the SHA1 taken from the
+#       specified line.
 #
-#   If a line number is prefixed with "squash", "fixup", "edit", or
-#   "reword", the respective line's command will be replaced with the
-#   specified one.
+#   "<cmd> <lineno>" -- add a line with the specified command
+#       ("squash", "fixup", "edit", or "reword") and the SHA1 taken
+#       from the specified line.
+#
+#   "#" -- Add a comment line.
+#
+#   ">" -- Add a blank line.
 
 set_fake_editor () {
 	echo "#!$SHELL_PATH" >fake-editor.sh
@@ -36,6 +43,10 @@ for line in $FAKE_LINES; do
 	case $line in
 	squash|fixup|edit|reword)
 		action="$line";;
+	"#")
+		echo '# comment' >> "$1";;
+	">")
+		echo >> "$1";;
 	*)
 		sed -n "${line}s/^pick/$action/p" < "$1".tmp >> "$1"
 		action=pick;;
-- 
1.6.6.140.ga53ad
Previous: Junio C HamanoNext: Michael Haggerty
Message 5 of 6 in “[PATCHv2 0/3] rebase-i: Ignore comments and blank lines among squash/fixup commands”
  1. Michael HaggertyJan 12, 2010
  2. Johannes SchindelinJan 12, 2010
  3. 1/3 lib-rebase: Provide clearer debugging info about what the editor didMichael Haggerty, Jan 12, 2010
  4. Junio C HamanoJan 13, 2010
  5. 2/3 lib-rebase: Allow comments and blank lines to be added to the rebase scriptMichael Haggerty, Jan 12, 2010
  6. 3/3 rebase-i: Ignore comments and blank lines in peek_next_commandMichael Haggerty, Jan 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.